Conversation
ota-meshi
approved these changes
Jun 26, 2025
Member
ota-meshi
left a comment
ota-meshi
left a comment
There was a problem hiding this comment.
It's really awesome! Thank you so much!
|
Hello! Could I ask why you copied the code instead of installing es-toolkit as a dependency? Since es-toolkit is actively being developed, I think it would be better to install and use it as a dependency! |
Contributor
Author
|
Hi @dayongkr ! I initially considered adding
I chose to copy the code. Welcome to share your thoughts. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #267
At first, I was going to have
lodashasdevDependenciesand bundle it in dist.Finally, as mentioned in ota-meshi/yaml-eslint-parser#210, I chose to copy these methods into this repository from
remedaandes-toolkit(has an installation size of 3.9 MiB).All tests are passed on my machine:
